Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project metadata #81

Merged
merged 10 commits into from
Jun 10, 2020
Merged

Project metadata #81

merged 10 commits into from
Jun 10, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented May 13, 2020

Specifies project-metadata originally proposed in RFC0013

This PR is derived from @iainsproat 's work on #68 w/ minor changes made to make label and environment names reflect the current implementation.

@ekcasey ekcasey requested a review from a team as a code owner May 13, 2020 17:53
@nebhale
Copy link
Contributor

nebhale commented May 20, 2020

@jkutner and @sclevine Can you please have a review of this PR?

platform.md Show resolved Hide resolved
@ekcasey ekcasey requested a review from sclevine June 3, 2020 14:05
iainsproat and others added 10 commits June 10, 2020 17:54
 - Add app source metadata format
 - [RFC0013](https://github.com/buildpack/rfcs/blob/master/text/0013-app-layer-metadata-source.md)

[#170205764]

Signed-off-by: Shane Huston <shuston@pivotal.io>
Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
* Changes will be moved to the platform specification document

This reverts commit 3dc1b44.

Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
* Moves the specification from Buildpack document to Platform document
* Adds a new optional `-platform` flag to the lifecycle builder
* Adds a new project.toml input file
* Includes source, source.version, and source.metadata properties to
project.toml
* Provides a new section to specify the Config labels to be added to the OCI
image
* Includes a data type for the "io.buildpacks.project" Config label.

[#170205764]

Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
[#170205764]

Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
* renamed flag to source-metadata
* created an Export Phase section
* removed redundant quotation marks from label key
* renamed TOML file to source-metadata.toml

[#170205764]

Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
* follows comments received on PR
** remove whitespace
** add section to Table of Contents
** Renames `source-metadata` to `project-metadata`

[#170205764]

Signed-off-by: Carlo Colombo <ccolombo@pivotal.io>
Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
- Renames OCI image to Exported image

[#170205764]

Signed-off-by: Velda Conaty <vconaty@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
* Derived from PR #68
* Paths and label names have been changes to match the concensus arrived at during implementation
  - buildpacks/lifecycle#230
  - buildpacks/lifecycle#257

Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey ekcasey merged commit 60c27ff into platform/0.3 Jun 10, 2020
@ekcasey ekcasey deleted the project-metadata branch June 10, 2020 22:00
@ekcasey ekcasey added this to the Platform 0.3 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants